Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPC functions to install/update SQL on configured databases #4021

Merged
merged 12 commits into from
Nov 11, 2024

Conversation

mathemancer
Copy link
Contributor

@mathemancer mathemancer commented Nov 8, 2024

Fixes #4017

This adds an RPC function, databases.upgrade_sql. It's documented as usual, and the documentation should suffice to describe its use.

It also adds some attributes to the Database model and exposes them in databases.configured.list:

  • last_confirmed_sql_version: The last version of the SQL scripts which were confirmed to have been run on the database.
  • needs_upgrade_attention: This is True if the SQL version isn't confirmed to be the same as the service version.

Technical details

The function will automatically determine the correct role to use for the upgrade if a username and password aren't submitted. If they are submitted, then the function will attempt to use the specified role.

This PR also includes some general clean up and simplification of our installation code.

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mathemancer mathemancer requested a review from Anish9901 November 8, 2024 09:21
@mathemancer mathemancer added this to the v0.2.0 (beta release) milestone Nov 8, 2024
@mathemancer mathemancer added the pr-status: review A PR awaiting review label Nov 8, 2024
@mathemancer mathemancer requested a review from pavish November 8, 2024 09:25
Copy link
Member

@Anish9901 Anish9901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor suggestion.

mathesar/models/base.py Outdated Show resolved Hide resolved
@Anish9901 Anish9901 removed their assignment Nov 8, 2024
@mathemancer mathemancer added this pull request to the merge queue Nov 11, 2024
Merged via the queue into develop with commit 7f2b6d0 Nov 11, 2024
49 checks passed
@mathemancer mathemancer deleted the rpc_sql_install branch November 11, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add backend functionality to allow upgrading SQL via RPC calls
2 participants