Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clarity of table inspector active tab #4047

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

seancolsen
Copy link
Contributor

@seancolsen seancolsen commented Dec 5, 2024

Fixes #2341

Motivation

I've found that it's easy to get confused between the "Table" and "Column" tabs of the table inspector because the UI within them it almost identical near the top. I've noticed this in usability sessions too. I ran this by Kriti as a quick thing to shore up as part of the usability and onboarding work that I'm doing for beta, and said it would be fine to address.

Before

Table Column
image image
  • "Properties", "Name", "Description" appear identically in both tabs, and it's only a very thin border to cue the user as to the context of these fields.

After

Table Column
image image
  • The red bottom border for the active tab is thicker
  • Inactive tabs get slightly lighter text color
  • Inspector sections include the words "Table" and "Column" for clarity
  • Fields include the words "Table" and "Column" for clarity
  • Table Permissions button is inside the "Table Properties" section to simplify the UI
  • All permissions modal buttons have a new custom icon for visual consistency and ease of identification

Notes

  • The changes to active tab styling also apply everywhere the tabs are used, which is several other places, e.g. permissions modals, schema page, table page, etc.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@seancolsen seancolsen added this to the v0.2.0 (beta release) milestone Dec 5, 2024
@seancolsen seancolsen added the pr-status: review A PR awaiting review label Dec 5, 2024
@seancolsen
Copy link
Contributor Author

@ghislaineguerin I've assigned you to review from a UX/design perspective.

@pavish I've assigned you to review code and also UX/design if you have any opinions.

Copy link
Contributor

@ghislaineguerin ghislaineguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pavish pavish added this pull request to the merge queue Dec 9, 2024
Merged via the queue into develop with commit 5493b7e Dec 9, 2024
70 checks passed
@pavish pavish deleted the inspector_tab_clarity branch December 9, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve design for highlighting the currently-selected tab in the table inspector
3 participants