Execute default expr when not dynamic. #4065
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3716
This adds logic that executes the stored default expression for a column and then formats it properly for the given type whenever it's not dynamic.
Technical details
This should bring the current logic up to parity with the older behavior, or better. Since we now apply the format function to the default before putting it in the JSON for return, we (for example) return Date-type defaults in the same ISO format as the column values. The front end seems to happily consume this.
I modified a test to make sure the new behavior is working.
Note that when the default is dynamic (e.g.,
now()
orGENERATED ALWAYS AS IDENTITY
), we don't attempt to execute it. This is for a number of reasons, but the most important is that we don't want to burn sequence values when listing the columns of a table.Screenshots
Before
After
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin