Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute default expr when not dynamic. #4065

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

mathemancer
Copy link
Contributor

@mathemancer mathemancer commented Dec 12, 2024

Fixes #3716

This adds logic that executes the stored default expression for a column and then formats it properly for the given type whenever it's not dynamic.

Technical details

This should bring the current logic up to parity with the older behavior, or better. Since we now apply the format function to the default before putting it in the JSON for return, we (for example) return Date-type defaults in the same ISO format as the column values. The front end seems to happily consume this.

I modified a test to make sure the new behavior is working.

Note that when the default is dynamic (e.g., now() or GENERATED ALWAYS AS IDENTITY), we don't attempt to execute it. This is for a number of reasons, but the most important is that we don't want to burn sequence values when listing the columns of a table.

Screenshots

Before

image

After

image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mathemancer
Copy link
Contributor Author

@seancolsen I requested an optional review from you to make sure that:

  • The behavior is as expected now from the API (I'm 90% sure it will be), and
  • the formatting in the DB layer won't somehow mess up the front end logic (I'm less sure about that, but I did try a few different types and didn't notice any visible problems).

Copy link
Contributor

@seancolsen seancolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍🏻

Copy link
Member

@Anish9901 Anish9901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Anish9901 Anish9901 enabled auto-merge December 13, 2024 10:41
@Anish9901 Anish9901 added this pull request to the merge queue Dec 13, 2024
Merged via the queue into develop with commit b928de2 Dec 13, 2024
70 checks passed
@Anish9901 Anish9901 deleted the default_formatting_bug branch December 13, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API returns column default value formatted differently from submitted
3 participants