Fix small problem with schema name in page titles #4074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rips out some weird low-level code that was inserting the schema name into HTML page
<title>
elements whenever possible. This code came to my attention because of theTODO_BETA
comment, but upon closer inspection, I noticed that it was causing this subtle (and low impact) bug where the schema name is included twice in the schema page:Much to my chagrin, apparently I wrote this logic back on 2022-09-20. But yuck, I do not like that! If we want the schema name to be in page titles, we ought to be setting that at a higher level, like here, where on some pages we know we have a schema and on other pages we know we do not have a schema. All in all, I don't think we actually need to worry about include the shcema name in page titles.
This PR simplifies things, removes the
TODO_BETA
comment, and fixes the bug. It does mean that table pages and record pages will no longer include the shcema name, but I don't think that's a problem.Checklist
Update index.md
).develop
branch of the repositoryDeveloper Certificate of Origin
Developer Certificate of Origin