Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: possible fix for the cell losing focus when clicking on the border #4080

Closed
wants to merge 8 commits into from
Closed

fix: possible fix for the cell losing focus when clicking on the border #4080

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
72f0295
possible fix for the cell losing focus when clicking on the border
sharathvgts Dec 16, 2024
5792faa
removed unwanted lines of code in the fix
sharathvgts Dec 16, 2024
a252750
fixed the style error by running prettier format
sharathvgts Dec 16, 2024
c287ad8
Merge branch 'develop' of https://github.com/mathesar-foundation/math…
sharath-1517 Dec 18, 2024
d301c0e
added the mentioned case sensitive and insensitive words in the filters
sharath-1517 Dec 18, 2024
32e976e
changed the visual changes back to default
sharath-1517 Dec 19, 2024
bf7373f
code linting fix
sharath-1517 Dec 19, 2024
64ae30b
code linting fix
sharath-1517 Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions mathesar_ui/src/components/cell-fabric/data-types/components/CellWrapper.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@
min-height: var(--cell-height, var(--default-cell-height));
display: flex;
flex-direction: column;
outline-offset: -2px;

&.has-padding {
padding: var(--cell-padding);
Expand All @@ -125,11 +126,11 @@
}

&[data-active-cell] {
box-shadow: 0 0 0 2px var(--slate-300);
outline: 2px solid var(--slate-300);
border-radius: 2px;

&:focus {
box-shadow: 0 0 0 2px var(--sky-700);
outline: 2px solid var(--sky-700);
}
}

Expand All @@ -140,9 +141,8 @@

&.is-edit-mode {
padding: 0px;
box-shadow:
0 0 0 3px var(--sky-700),
0 0 8px #000000 !important;
outline: 3px solid var(--sky-700);
outline-offset: -3px;
}

&.truncate {
Expand Down
1 change: 0 additions & 1 deletion mathesar_ui/src/components/sheet/cells/SheetDataCell.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@

[data-cell-active] {
z-index: var(--z-index__sheet__active-cell);
border-color: transparent;
min-height: 100%;
height: auto;
}
Expand Down
Loading