Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep toggleOpen() from displaying inline CSS or JS on the page #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattbrundage
Copy link

No description provided.

@tchalvak
Copy link

tchalvak commented Sep 3, 2019

Makes sense, though perhaps it’s not ideal to put those elements inside details.

@pthorson
Copy link

pthorson commented Oct 9, 2019

I'm curious about how to repeat this issue.

It appears to me that in IE11, jQuery 1.12 will always flag script and style nodes as display none. (That depends on the result of a call to defaultDisplay("SCRIPT"))

@mattbrundage
Copy link
Author

@pthorson , here's a reduced test case: https://codepen.io/mattbrundage/full/gOOarjN
Notice that when you show contents, the inline CSS and JS appear in IE and Edge.

@tchalvak while it's not ideal, <script> is a valid direct descendant of the <details> element.

@pthorson
Copy link

@mattbrundage Thank you for the test case. I was testing with an older version of jQuery. Looks like they changed behavior for those elements at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants