Fix casting embedded schema with no fields and type on parent #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping :) |
mathieuprog
reviewed
Dec 8, 2024
| @@ -185,9 +185,6 @@ defmodule PolymorphicEmbed do | |||
| {:ok, nil} when not required -> | |||
| Ecto.Changeset.put_change(changeset, field, nil) | |||
|
|
|||
| {:ok, map} when map == %{} and not array? -> | |||
There was a problem hiding this comment.
any reason this clause was removed?
There was a problem hiding this comment.
With this clause not removed, when there is an empty schema (an embedded schema with no fields), the casting will not work as this clause will stop the casting early.
You can try bringing this back and see the added test fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Firstly thank you for the great library.
Right now when casting an embedded schema that has no fields with type on parent schema, the casting ignores an empty map.
With this fix, an empty map will also be casted.