Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(🌱): minor enhancements #74

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

Conversation

Walidoux
Copy link
Collaborator

@Walidoux Walidoux commented Feb 27, 2024

This PR introduces features, fixes, and many changes which can be found below
Everything described here is subject to change ⚠️

Features

  • tsup: code splitting (multiple index.ts entry points) to load JS in production when needed
  • RoomPreview.ts: preview floor + interactions to add/remove tiles and their height
  • HMR: Vite HMR's API prevents reloading the entire page whenever changes are made, the room is destroyed instead and re-rendered for a fast dev environment.

Fixes

  • GreedyMesher.ts: Stairs are merged where they shouldn't be
  • RoomHeightMap.ts: improve conditional stairs logic
  • Sorting.ts: just fix everything
  • Camera
    • RoomCamera.ts: unbind listeners when the room is destroyed
    • pre-zooming when zoom.level changes
    • Fix issues with devicePixelRatio, zoom and drag

Refactors

  • Move pixi-stats & pixi-devtools outside the package
    (they shouldn't be bundled with the final package, thus reduce the bundle size)
  • Stairs:
    • hitarea not allowing clicks on stairs
    • Floating cube faces around stairs + new stair type

image

Changelog

  • Add configurable camera movement speed

@Walidoux Walidoux requested a review from mathishouis February 27, 2024 13:38
@Walidoux Walidoux self-assigned this Feb 27, 2024
@Walidoux Walidoux added enhancement New feature or request help wanted Extra attention is needed labels Feb 27, 2024
@Pi-Bouf
Copy link

Pi-Bouf commented Feb 28, 2024

I love this work ! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants