Fixing duplicate state in React-Dockview-Demo caused by strict mode #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bsequent onReady calls Strict Mode causes the Dockview component to render twice, causing onReady to be called twice, which puts two copies of DefaultLayout in state without resetting between calls. A most-ideal solution would probably be to expose an onUnload hook or something like that, to be called after one onReady but before the next. Then, the state resets could be called in that hook. but this fix will at least ensure the Dockview-Demo codesandbox behaves nicely for the time being.
see prev. commit
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 10fd577:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Dockview-Demo on CodeSandbox looks like this:
As far as I can tell, This seems to be because strict mode causes the Dockview to load, unload, then load again, which causes onReady to be called twice, which causes DefaultLayout to be called twice, which puts two copies of the default layout into state. (Groups state & Panels state)
As I see it, there are a few possible solutions here:
Dockview could be changed to call each onDidRemoveGroup and onDidRemovePanel hook while unloading, causing Group and Panel state to update naturally in their associated hooks.
Dockview could expose an onWillUnload hook, mirror to the onReady hook, that gets called when Dockview starts unloading. Then, state resets could be placed in there.
You can just place your state resets in onReady. This is the band-aid fix I'm proposing here.
Either way, at the end of it the Dockview-Demo codesandbox should look like this. This is the intent of this pull request.