Skip to content

Commit

Permalink
Merge pull request #55 from mathworks/metrics_cleanup
Browse files Browse the repository at this point in the history
back out a change to replace spaces in instrument names with underscore
  • Loading branch information
duncanpo authored Nov 9, 2023
2 parents 123f9f9 + 94b9293 commit 6d492c9
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions api/metrics/+opentelemetry/+metrics/Meter.m
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
ctname = mustBeScalarString(ctname);
% cpp-opentelemetry end does not allow string input with spaces,
% replace any spaces with underscores as a temporary fix
ctname = strrep(ctname, ' ', '_');
ctdescription = mustBeScalarString(ctdescription);
ctunit = mustBeScalarString(ctunit);
id = obj.Proxy.createCounter(ctname, ctdescription, ctunit);
Expand All @@ -62,7 +61,6 @@
ctname = mustBeScalarString(ctname);
% cpp-opentelemetry end does not allow string input with spaces,
% replace any spaces with underscores as a temporary fix
ctname = strrep(ctname, ' ', '_');
ctdescription = mustBeScalarString(ctdescription);
ctunit = mustBeScalarString(ctunit);
id = obj.Proxy.createUpDownCounter(ctname, ctdescription, ctunit);
Expand All @@ -84,7 +82,6 @@
hiname = mustBeScalarString(hiname);
% cpp-opentelemetry end does not allow string input with spaces,
% replace any spaces with underscores as a temporary fix
hiname = strrep(hiname, ' ', '_');
hidescription = mustBeScalarString(hidescription);
hiunit = mustBeScalarString(hiunit);
id = obj.Proxy.createHistogram(hiname, hidescription, hiunit);
Expand Down

0 comments on commit 6d492c9

Please sign in to comment.