Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid instrument names with spaces #29

Merged
merged 2 commits into from
Oct 6, 2023
Merged

fix: invalid instrument names with spaces #29

merged 2 commits into from
Oct 6, 2023

Conversation

ricktu-mw
Copy link
Member

@ricktu-mw
fix: invalid instrument names with spaces
68a0985 
temporary fix for issue #28;
change size to numel in tmetrics
duncanpo
duncanpo requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@duncanpo duncanpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment about why we need to replace empty space with underscore.

api/metrics/+opentelemetry/+metrics/Meter.m Show resolved Hide resolved
@ricktu-mw
fix: comments
e995d79 
add comments on using strrep for name input of synchronous instruments
@duncanpo duncanpo merged commit 9af0a3d into metrics Oct 6, 2023
1 check passed
@duncanpo duncanpo deleted the metrics_reader branch October 10, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanpo duncanpo duncanpo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricktu-mw @duncanpo