Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Resource Property to MeterProvider #48

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Adding Resource Property to MeterProvider #48

merged 6 commits into from
Nov 2, 2023

Conversation

dnarula-mw
Copy link
Contributor

This PR adds the Resource property to MeterProvider. It also creates the test class tmetrics_sdk with one method to test the resource property.

duncanpo
duncanpo requested changes Nov 2, 2023
View reviewed changes
Copy link
Member

@duncanpo duncanpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the one issue and I will accept

sdk/metrics/+opentelemetry/+sdk/+metrics/MeterProvider.m Outdated Show resolved Hide resolved
@duncanpo
Copy link
Member

duncanpo commented Nov 2, 2023

Implemented issue #33

@dnarula-mw dnarula-mw merged commit b7bb9cf into metrics Nov 2, 2023
1 check passed
@dnarula-mw dnarula-mw deleted the meter_provider_resource branch November 2, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanpo duncanpo duncanpo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnarula-mw @duncanpo