Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable Cleanup class to work for SDK objects #51

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

duncanpo
Copy link
Member

@duncanpo duncanpo commented Nov 8, 2023

Also merge Cleanup classes for metrics and tracing into one class in common package.
Implemented #43

@duncanpo duncanpo requested a review from dnarula-mw November 8, 2023 19:22
Copy link
Contributor

@dnarula-mw dnarula-mw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.

@duncanpo duncanpo merged commit ccacea4 into metrics Nov 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants