Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics cleanup #53

Closed
wants to merge 52 commits into from
Closed

Metrics cleanup #53

wants to merge 52 commits into from

Conversation

duncanpo
Copy link
Member

@duncanpo duncanpo commented Nov 9, 2023

  • Improve handling of complex numbers (no-op instead of error)
  • More code sharing between synchronous metric instruments. The "add" method of the counters and the "record" method of the histogram have identical code in the M layer. Combining them into one.
  • Move SDK related metrics tests into tmetrics_sdk
  • Push more test setup code into the test setup methods

ricktu-mw and others added 30 commits September 25, 2023 12:24
@ricktu-mw
feat: metric_exporter, metric_reader
f6a1c55 
draft version of metric reader and exporter
@ricktu-mw
update 1
0984062
@ricktu-mw
v2
98bd3a6
@ricktu-mw
v2
4d8b990
@ricktu-mw
v2
081f16e
@ricktu-mw
v3
dd8e0e9
@ricktu-mw
v4
cc9cf8f 
add counter test for aggregation temporality as delta
@ricktu-mw
v5
883f261 
fix cmakelist
@ricktu-mw
v6
137fed8 
clear meter provider before read json results (which terminates collector) in tmetrics.
@duncanpo
Merge pull request #25 from mathworks/changes_after_v_1_3_0
ba013e1 
Push examples into metrics
@ricktu-mw
v7
1b833de 
fix indexing in tmetrics
add histogram test with delta temporality
@ricktu-mw
v8: addMetricReader
6380ae1 
implemented addMetricReader;
add test for addMetricReader
@ricktu-mw
v9: update comments
300445c 
update comments for metric exporters
remove json output file
@duncanpo
Merge pull request #26 from mathworks/metrics_reader
2636072 
feat: metrics reader and exporter
@dnarula-mw
Creating MeterProvider API
40ecc12
@ricktu-mw
fix: invalid instrument names with spaces
68a0985 
temporary fix for issue #28;
change size to numel in tmetrics
@dnarula-mw
Finishing and cleaning up MeterProvider api
1773af8
@ricktu-mw
fix: comments
e995d79 
add comments on using strrep for name input of synchronous instruments
@duncanpo
Merge pull request #29 from mathworks/metrics_reader
9af0a3d 
fix: invalid instrument names with spaces
@duncanpo
Merge pull request #38 from mathworks/changes_after_v_1_3_0
6e11722 
Add badges to README
@dnarula-mw
Adding test for get and set meter
ac793c5
@dnarula-mw
Resolving merge conflicts
a0777dd
@dnarula-mw
Fixing error from merge
ec00310
@dnarula-mw
Removing .vs folder
3af790a
@dnarula-mw
Add resource property
8c3a10c
@dnarula-mw
Lowering reader interval for test
8268a15
@dnarula-mw
clearning meter provider in test
f9b7c45
@dnarula-mw
fixing typo
39e01fa
@dnarula-mw
Addressing PR comments
a630aa7
@dnarula-mw
Fixing crash and comment out test
fd75583
duncanpo and others added 22 commits October 12, 2023 16:17
@duncanpo
Merge pull request #39 from mathworks/meter_provider_api
cf7f8ec 
Meter provider api
@dnarula-mw
Adding shutdown and forceflush to fix getsetmeterprovider test
ff030ae
@dnarula-mw
Clean up code and finish shutdown
e1c58c4
@dnarula-mw
Removing unnecessary change in tests
e245e2e
@dnarula-mw
Addressing pull request comments
caab36b
@dnarula-mw
Merge pull request #42 from mathworks/meter_provider_api
60acf06 
Add shutdown and forceflush to Meter Provider
@dnarula-mw
Fixing merge conflicts
f21e7c6
@duncanpo
Make metric reader and exporter properties editable
f3884c3
@duncanpo
Merge pull request #46 from mathworks/metrics_readonly_props
66b73f2 
Make metric reader and exporter properties editable
@dnarula-mw
Finishing add resource property to metrics
58392ca
@dnarula-mw
Merge branch 'metrics' into meter_provider_resource
3e9a03f
@duncanpo
add a test about issue #34
b90544a
@dnarula-mw
Cleaning up code
ee27f2b
@duncanpo
Merge pull request #47 from mathworks/metrics_readonly_props
2628bd7 
add a test about issue #34
@dnarula-mw
Change error message
ac97746
@dnarula-mw
Merge pull request #48 from mathworks/meter_provider_resource
b7bb9cf 
Adding Resource Property to MeterProvider
@dnarula-mw
Correctly clearing meter providers
2bff102
@duncanpo
add a SynchronousInstrument base class
4a12e67
@duncanpo
Merge pull request #50 from mathworks/fixing_tests
b6e18f9 
Correctly clearing meter providers
@duncanpo
Merge pull request #49 from mathworks/sync_instrument
af1a71c 
add a SynchronousInstrument base class
@duncanpo
enable Cleanup class to work for SDK objects
adb6cd3
@duncanpo
Complex number handling and more code sharing between metric instruments
9f9fbc7
@duncanpo duncanpo requested a review from dnarula-mw November 9, 2023 19:25
@duncanpo
Copy link
Member Author

duncanpo commented Nov 9, 2023

wrong destination branch. Closing.

@duncanpo duncanpo closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnarula-mw dnarula-mw Awaiting requested review from dnarula-mw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duncanpo @ricktu-mw @dnarula-mw