feat(rules): add MultiplicativeInverse rule #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- for handling / in expressions
✅ Deploy Preview for friendly-daifuku-ae17d2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 88.69% 89.49% +0.80%
==========================================
Files 21 22 +1
Lines 2520 2560 +40
==========================================
+ Hits 2235 2291 +56
+ Misses 285 269 -16 ☔ View full report in Codecov by Sentry. |
- oops, the md was being ignored multiply vs multiplication. naming is hard. consistency is also hard.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
## [0.9.4](v0.9.3...v0.9.4) (2024-02-06) ### Features * **rules:** add MultiplicativeInverse rule ([#19](#19)) ([40a2d88](40a2d88))
|
🎉 This PR is included in version 0.9.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People keep asking why mathy can't handle "4x / (2x + 7)" and friends. Division isn't supported for our workhorse rules like Distributive Property, Commutative Property, etc.
Luckily we can use the multiplicative inverse rule to transform division into a multiplication of the reciprocal of the denominator.
This is most easily explained with an example
4 / 2 = 4 * 1 / 2.After conversion, expressions can be further simplified with other rules.