Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove password when confirmation modal is closed #22754

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Remove password when confirmation modal is closed #22754

merged 4 commits into from
Nov 18, 2024

Conversation

michalkleiner
Copy link
Contributor

Description:

As per the title, plus UI tests.

Ref. DEV-12809

Review

@michalkleiner michalkleiner added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review labels Nov 17, 2024
@michalkleiner michalkleiner marked this pull request as ready for review November 17, 2024 22:09
@michalkleiner michalkleiner added this to the 5.2.0 milestone Nov 17, 2024
caddoo
caddoo previously approved these changes Nov 18, 2024
@michalkleiner
Copy link
Contributor Author

@caddoo there was a typo in one of the UI test expected screenshot names, I've corrected that. Can you please re-approve? Ta!

@sgiehl sgiehl merged commit be6e42b into 5.x-dev Nov 18, 2024
25 of 26 checks passed
@sgiehl sgiehl deleted the dev-17809 branch November 18, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants