Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update path to Jinja2 templates #180

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ConorMacBride
Copy link
Member

A test from #179 was showing:

ValueError: The 'pytest_mpl.summary.html' package was not installed in a way that PackageLoader understands.

The update in this PR might fix that as it follows the PackageLoader docs, although we should check why it usually works with pytest_mpl.summary.html.

@QuLogic
Copy link
Member

QuLogic commented Nov 29, 2022

This warning may also be relevant:

  /usr/lib/python3.11/site-packages/setuptools/command/build_py.py:202: SetuptoolsDeprecationWarning:     Installing 'pytest_mpl.summary.templates' as data is deprecated, please list it in `packages`.
      !!


      ############################
      # Package would be ignored #
      ############################
      Python recognizes 'pytest_mpl.summary.templates' as an importable package,
      but it is not listed in the `packages` configuration of setuptools.

      'pytest_mpl.summary.templates' has been automatically added to the distribution only
      because it may contain data files, but this behavior is likely to change
      in future versions of setuptools (and therefore is considered deprecated).

      Please make sure that 'pytest_mpl.summary.templates' is included as a package by using
      the `packages` configuration field or the proper discovery methods
      (for example by using `find_namespace_packages(...)`/`find_namespace:`
      instead of `find_packages(...)`/`find:`).

      You can read more about "package discovery" and "data files" on setuptools
      documentation page.


  !!

    check.warn(importable)
  creating build/lib/pytest_mpl/summary/templates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants