Allow using -p no:legacypath
with pytest
>= 7
#213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-p no:legacypath
option forpytest
prevents using legacypy.path
and forces usingpathlib
from the Python standard library instead. 07e12f4 attempted to remove all uses ofpy.path
withpytest
>= 7 so that downstream packages could use that option, (at least with recent enoughpytest
). That commit introduced usinggetattr()
to access thepath
attribute of_pytest.nodes.Node
instances and falling back to thefspath
attribute ifpath
does not exist (which happens withpytest
< 7). However, evaluating thedefault
forgetattr()
then guarantees thatfspath
is accessed, which is incompatible with-p no:legacypath
. The simplest way of avoiding accessingfspath
is to use explicitly version-dependent code.