Deprecate getters/setters and annotate client.py with TODO project plans #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we don't have an architecture or design document for this sdk, the TODO comments I've left throughout client.py should at least give people the start of my ideas for this project's future. Signed-off-by: Adam Beckmeyer <[email protected]>
Signed-off-by: Adam Beckmeyer <[email protected]>
Signed-off-by: Adam Beckmeyer <[email protected]>
|
I've looked through it and it generally looks sane. FYI, my next PR already moves _process_state_event to the room object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Matrixcoffee could you review this for me? It's the start of my attempt to address your general concerns from #192.
Getters/setters are being removed as they're considered poor python style, and there are ways to make normal attribute access behave like a getter/setter if necessary in the future.