Improve static type checking #225
Conversation
Add type annotation to is_too_long Function on apnstruncate.py file as part of #201 issue Signed-off-by: Omar Mohamed <[email protected]>
as part of #201 issue Signed-off-by: Omar Mohamed <[email protected]>
sygnal/apnstruncate.py
Outdated
| @@ -26,7 +26,7 @@ class BodyTooLongException(Exception): | |||
| pass | |||
|
|
|||
|
|
|||
| def is_too_long(payload, max_length=2048): | |||
| def is_too_long(payload: Dict[Any, Any], max_length: int = 2048) -> bool: | |||
There was a problem hiding this comment.
Looks like the type annotation you want is dict here (instead of Dict[Any, Any]).
There was a problem hiding this comment.
on it, Thank you :)
There was a problem hiding this comment.
Now that you've changed that with 8ae8f52 you'll also want to remove the import to typing.Dict on line 18 since it's not used anymore.
There was a problem hiding this comment.
Thank you, I have just removed it after seeing my test fails.
There was a problem hiding this comment.
@babolivier is there a difference between typing.Dict and dict on python versions?
while running mypy --strict sygnal/ tests/ setup.py I'm getting an error 👇
I'm running python 3.8
Line 29 in 656c0ea
Signed-off-by: Omar Mohamed <[email protected]>
Signed-off-by: Omar Mohamed <[email protected]>
|
Thanks for your contribution! :) |
Add type annotation to is_too_long Function on apnstruncate.py file
as part of the #201 issue