Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move LLVM-independent data to common #127

Merged

Conversation

hedgar2017
Copy link
Collaborator

What ❔

Moves some LLVM-unrelated definitions to the common crate.

Why ❔

They can be useful for some crates that doesn't want to depend on LLVM.

Checklist

  • PR title corresponds to the body of PR.
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and checked with cargo clippy.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 23.94%. Comparing base (4daf358) to head (6f48cf3).

Files Patch % Lines
src/zksolc/main.rs 0.00% 5 Missing ⚠️
src/lib.rs 0.00% 4 Missing ⚠️
src/process/mod.rs 25.00% 3 Missing ⚠️
src/project/contract/mod.rs 0.00% 1 Missing ⚠️
src/project/thread_pool_evm.rs 0.00% 1 Missing ⚠️
src/solc/standard_json/input/settings/metadata.rs 0.00% 1 Missing ⚠️
src/zksolc/arguments.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   23.97%   23.94%   -0.03%     
==========================================
  Files         106      106              
  Lines       14734    14721      -13     
==========================================
- Hits         3532     3525       -7     
+ Misses      11202    11196       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[skip ci]
@hedgar2017 hedgar2017 force-pushed the az-cpr-1794-split-target-parameter-of-compiler-tester branch from 6f48cf3 to a642b96 Compare August 16, 2024 13:38
@hedgar2017 hedgar2017 merged commit 1e0cade into main Aug 16, 2024
@hedgar2017 hedgar2017 deleted the az-cpr-1794-split-target-parameter-of-compiler-tester branch August 16, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant