Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use create_justification in the quint specification as in the informal spec #218

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

konnov
Copy link
Collaborator

@konnov konnov commented Nov 27, 2024

What ❔

  • Update the Quint specification to call create_justification in start_new_view, instead of passing justifications directly.
  • Replace get_justification(view) with create_justification() in replica.rs to reflect the discussed changes.

Why ❔

The pseudo code specification uses create_justification in start_new_view and proposer_step. The Quint specification was passing a justification directly in start_new_view. These two approaches are not entirely equivalent.

A falsy invariant high_commit_and_timeout_qc_example demonstrates that it's possible for a replica to have both high_timeout_qc and high_commit_qc to have the same view. The model checker found an execution that demonstrates it.

@konnov konnov changed the title Use create_justification in the quint specification as in the informal spec refactor: use create_justification in the quint specification as in the informal spec Nov 27, 2024
@konnov
Copy link
Collaborator Author

konnov commented Nov 27, 2024

It's interesting that the Typos job complains about a spell checking issue in a file that is not touched by this PR:

error: parametrized should be parameterized
--> ./node/libs/concurrency/src/scope/state.rs:3:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants