Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: N-06 Typographical Errors #987

Draft
wants to merge 2 commits into
base: library-fix-review
Choose a base branch
from
Draft

fix: N-06 Typographical Errors #987

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cca49de
fix: N-06 Typographical Errors
kelemeno Oct 25, 2024
1234f1e
typo
kelemeno Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion l1-contracts/contracts/common/L2ContractAddresses.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ interface IL2Messenger {
/// if the assetId can be calculated with this address then it is in fact an NTV asset
address constant L2_NATIVE_TOKEN_VAULT_ADDR = address(0x10004);

/// @dev the address of the l2 asse3t router.
/// @dev the address of the l2 asset router.
address constant L2_MESSAGE_ROOT_ADDR = address(0x10005);

/// @dev the offset for the system contracts
Expand Down
10 changes: 5 additions & 5 deletions system-contracts/contracts/L2GenesisUpgrade.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

pragma solidity 0.8.24;

import {DEPLOYER_SYSTEM_CONTRACT, SYSTEM_CONTEXT_CONTRACT, L2_BRIDDGE_HUB, L2_ASSET_ROUTER, L2_MESSAGE_ROOT} from "./Constants.sol";
import {DEPLOYER_SYSTEM_CONTRACT, SYSTEM_CONTEXT_CONTRACT, L2_BRIDGE_HUB, L2_ASSET_ROUTER, L2_MESSAGE_ROOT} from "./Constants.sol";
import {IContractDeployer, ForceDeployment} from "./interfaces/IContractDeployer.sol";
import {SystemContractHelper} from "./libraries/SystemContractHelper.sol";
import {ISystemContext} from "./interfaces/ISystemContext.sol";
Expand All @@ -28,20 +28,20 @@ contract L2GenesisUpgrade is IL2GenesisUpgrade {
// (The comment does not mention the exact order in case it changes)
// However, there is still some follow up finalization that needs to be done.

address bridgehubOwner = L2_BRIDDGE_HUB.owner();
address bridgehubOwner = L2_BRIDGE_HUB.owner();

bytes memory data = abi.encodeCall(
L2_BRIDDGE_HUB.setAddresses,
L2_BRIDGE_HUB.setAddresses,
(L2_ASSET_ROUTER, _ctmDeployer, address(L2_MESSAGE_ROOT))
);

(bool success, bytes memory returnData) = SystemContractHelper.mimicCall(
address(L2_BRIDDGE_HUB),
address(L2_BRIDGE_HUB),
bridgehubOwner,
data
);
if (!success) {
// Progapatate revert reason
// Propagate revert reason
assembly {
revert(add(returnData, 0x20), returndatasize())
}
Expand Down
Loading