Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move impersonation management into its own component #391

Merged
merged 2 commits into from
Nov 20, 2024
Merged

refactor: move impersonation management into its own component #391

merged 2 commits into from
Nov 20, 2024

Conversation

itegulov
Copy link
Contributor

What 💻

Closes #390 (see for more motivation)

Why ✋

Less dependence on the InMemoryNodeInner state, needed for #362

@itegulov itegulov requested a review from a team as a code owner November 20, 2024 06:10
@itegulov itegulov merged commit 2b5a128 into main Nov 20, 2024
10 checks passed
@itegulov itegulov deleted the daniyar/impersonation-manager branch November 20, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc approved these changes

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: move impersonation management into its own component
2 participants
@itegulov @popzxc