Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Nonce mismatches what network expects #726

Merged
merged 22 commits into from
Nov 21, 2024
Merged

fix: Nonce mismatches what network expects #726

merged 22 commits into from
Nov 21, 2024

Conversation

Jrigada
Copy link
Contributor

@Jrigada Jrigada commented Nov 14, 2024

What 💻

  • Fix error where network nonce does not match the tracked nonce

Why ✋

  • For each call and create in a test or script we were updating the nonce which lead to a mismatch with what the network expects

@Jrigada Jrigada requested a review from a team as a code owner November 14, 2024 14:46
@Jrigada Jrigada marked this pull request as draft November 14, 2024 14:53
@Jrigada Jrigada marked this pull request as ready for review November 14, 2024 15:00
elfedy
elfedy reviewed Nov 14, 2024
View reviewed changes
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/forge/tests/fixtures/zk/NonceMismatch.t.sol Outdated Show resolved Hide resolved
crates/forge/tests/fixtures/zk/ScriptSetup.s.sol Outdated Show resolved Hide resolved
crates/forge/tests/it/zk/setup_script.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
elfedy
elfedy previously approved these changes Nov 14, 2024
View reviewed changes
nbaztec
nbaztec reviewed Nov 15, 2024
View reviewed changes
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/zksync/core/src/cheatcodes.rs Outdated Show resolved Hide resolved
crates/zksync/core/src/vm/inspect.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
nbaztec
nbaztec reviewed Nov 16, 2024
View reviewed changes
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
@nbaztec
chore: explicit behavior for nonce update persistence (#729)
57db920 
* explicit behavior for nonce update persistence

* prevent short-circuit bug
nbaztec
nbaztec reviewed Nov 19, 2024
View reviewed changes
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
@Jrigada Jrigada requested a review from Karrq November 19, 2024 20:05
Karrq
Karrq reviewed Nov 20, 2024
View reviewed changes
crates/forge/src/runner.rs Outdated Show resolved Hide resolved
crates/forge/tests/fixtures/zk/ScriptSetup.s.sol Show resolved Hide resolved
crates/script/src/runner.rs Show resolved Hide resolved
@Jrigada Jrigada merged commit f83f08e into main Nov 21, 2024
12 checks passed
@Jrigada Jrigada deleted the jrigada-fix-nonce-mismatch-scripts branch November 21, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karrq Karrq Karrq approved these changes

@elfedy elfedy Awaiting requested review from elfedy

@nbaztec nbaztec Awaiting requested review from nbaztec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jrigada @nbaztec @Karrq @elfedy