fix: compute stored test address after setting the tx nonce on scripts #727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Compute and store test address after (optionally) updating the deployer nonce on scripts.
Why ✋
Closes #720
On instances where
evm_opts.sender
is the same as theCALLER
constant (which is the default value, happening for example when no raw private key is sent when invokingscript
), the nonce of the deployer of the script is modified to prevent nonce mismatches between simulation and execution. In that case we need to compute the test address with that modified nonce, so that we correctly forward calls/creates involving it to the EVM.Evidence 📷
Added test fails before the change and passes after. Also running scripts with
--account
--password
now work as intended (previously,setUp
andrun
were invoked on the zkEVM causing undefined behavior).