feat(zk_toolbox): Make chain init independent from ecosystem #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/zksync-era into matias/separate-chain-create
…bs/zksync-era into matias/separate-chain-create
…bs/zksync-era into matias/separate-chain-create
…/zksync-era into matias/separate-chain-init
matias-gonz
changed the title
…/zksync-era into matias/separate-chain-init
Deniallugo
reviewed
Nov 20, 2024
| ) -> anyhow::Result<PathBuf> { | ||
| let ecosystem_preexisting_configs_path = ecosystem.map_or_else( | ||
| || chain.get_preexisting_ecosystem_contracts_path(), | ||
| |e| e.get_preexisting_ecosystem_contracts_path(), |
There was a problem hiding this comment.
why not contracts path?
There was a problem hiding this comment.
Fixed!
537a33b
There was a problem hiding this comment.
hm, but why do we actually need this map? why not always use chain?
Deniallugo
reviewed
Nov 20, 2024
Comment on lines
+95
to
+118
| let ecosystem_contracts_path = if self.dev { | ||
| self.ecosystem_contracts_path.map_or_else( | ||
| || { | ||
| ecosystem.as_ref().map_or_else( | ||
| || chain.get_preexisting_ecosystem_contracts_path(), | ||
| |e| e.get_contracts_path(), | ||
| ) | ||
| }, | ||
| PathBuf::from, | ||
| ) | ||
| } else if let Some(ecosystem) = &ecosystem { | ||
| ecosystem.get_contracts_path() | ||
| } else { | ||
| get_ecosystem_contracts_path(self.ecosystem_contracts_path, ecosystem.clone(), chain)? | ||
| }; | ||
|
|
||
| let wallets_path = ecosystem.map_or_else( | ||
| || { | ||
| self.wallets_path | ||
| .map_or_else(|| Prompt::new(MSG_WALLETS_PATH_PROMPT).ask(), PathBuf::from) | ||
| }, | ||
| |e| e.get_wallets_path(), | ||
| ); | ||
|
|
There was a problem hiding this comment.
from messages it's not clear what contracts and wallets you want
There was a problem hiding this comment.
I updated the wallets message in: f194e18
Is this OK or what should the message be?
There was a problem hiding this comment.
Prompt for contracts path is:
Provide the path to the ecosystem contracts or keep it empty and you will use ZKsync ecosystem config. For using this config, you need to have governance wallet
How can we improve it?
…bs/zksync-era into matias/separate-chain-create
…/zksync-era into matias/separate-chain-init
…bs/zksync-era into matias/separate-chain-create
…/zksync-era into matias/separate-chain-init
…in subcommand (#3322) ## What ❔ Preload chain and ecosystem config before each chain subcommand
Base automatically changed from
matias/separate-chain-create
to
matias/refactor-chain-commands
November 26, 2024 14:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.