feat(zkstack): Separate chain deploy l2 contracts #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matias-gonz
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet,
otani88 and
iluwaa
Deniallugo
reviewed
Nov 22, 2024
| @@ -172,6 +174,7 @@ impl ChainConfig { | |||
| wallet_creation: self.wallet_creation, | |||
| legacy_bridge: self.legacy_bridge, | |||
| evm_emulator: self.evm_emulator, | |||
| l1_wallets_path: Some(self.l1_wallets_path.clone()), | |||
Deniallugo
reviewed
Nov 22, 2024
Comment on lines
+52
to
+55
| let wallets = ecosystem.as_ref().map_or( | ||
| WalletsConfig::read(shell, chain.l1_wallets_path.clone()), | ||
| |e| e.get_wallets(), | ||
| )?; |
There was a problem hiding this comment.
if we need wallets, from ecosystem, probably this function doesn't belong here.
There was a problem hiding this comment.
@sanekmelnikov What have you done in your pr?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.