feat: Use zeroes instead of simulator states as unused part of RAM permutation witness #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xVolosnikov
force-pushed
the
vv-simplify-ram-witgen-initial
branch
from
1a98048
to
3cc3e50
Compare
|
Additional cleanup, especially related to memory queues simulators, will also be in the next PR-s |
0xVolosnikov
changed the title
|
Did you have a successful generation of proofs after that change? If yes, we can accept |
|
But do you think if it's easier to change circuits code to update the type of witness, so it doesn't even bear those zeroed fields? |
Yes
Yes, but I would like to do this separately, perhaps as part of a general update. Since it would break backward compatibility. But yes, this is generally the next step: #48 |
shamatar
approved these changes
Oct 1, 2024
0xVolosnikov
pushed a commit
that referenced
this pull request
Oct 16, 2024
🤖 I have created a release *beep* *boop* --- ## [0.150.6](v0.150.5...v0.150.6) (2024-10-07) ### Features * Remove unneeded data and calculations from simulators in witgen ([#18](#18)) ([7316caf](7316caf)) * Reorganize witgen ([#49](#49)) ([9bf5cf8](9bf5cf8)) * Use zeroes instead of simulator states as unused part of RAM permutation witness ([#47](#47)) ([a336980](a336980)) ### Bug Fixes * Simplify closed_form_witness_from_full_form ([#38](#38)) ([af3d4c4](af3d4c4)) * **zkevm_test_harness:** Reduce ExtendedLogQuery RAM usage ([#44](#44)) ([eecf79a](eecf79a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since queue states ([F; SW] part of witness) aren't actually used by RAM permutation circuit, we can remove this RAM-heavy data from witness for this type of circuits.
This PR is first part of this change, which aims to be backwards compatible with current proving subsystem. Another PR that breaks backwards compatibility will contain removal of this field from the RAM witness completely.