[GH-65] #75
[GH-65] #75
Conversation
|
Hello @maisnamrajusingh, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
| for _, tn := range teamNameSlice { | ||
| teams[tn] = struct{}{} | ||
| } |
There was a problem hiding this comment.
Does spaces need to also be trimmed here?
There was a problem hiding this comment.
@hanzei this won't be needed here.
| @@ -57,7 +57,7 @@ func (p *Plugin) getSiteURL() string { | |||
| return *config.ServiceSettings.SiteURL | |||
| } | |||
|
|
|||
| func (p *Plugin) newSampleMessageTemplate(teamName, userID string) (*MessageTemplate, error) { | |||
| func (p *Plugin) newSampleMessageTemplate(teamID string, userID string) (*MessageTemplate, error) { | |||
There was a problem hiding this comment.
@hanzei Yes, doing just that. Will update you once done.
There was a problem hiding this comment.
These change still seem to come from #74 (comment). Once you dropped them from the file, I'n happy to approve it.
|
@maisnamrajusingh Please let me know when this is ready for a re-review |
yup it is. |
Co-authored-by: Jason Frerich <[email protected]>
|
@maisnamrajusingh, you're good from my end. Thanks! |
| @@ -57,7 +57,7 @@ func (p *Plugin) getSiteURL() string { | |||
| return *config.ServiceSettings.SiteURL | |||
| } | |||
|
|
|||
| func (p *Plugin) newSampleMessageTemplate(teamName, userID string) (*MessageTemplate, error) { | |||
| func (p *Plugin) newSampleMessageTemplate(teamID string, userID string) (*MessageTemplate, error) { | |||
There was a problem hiding this comment.
These change still seem to come from #74 (comment). Once you dropped them from the file, I'n happy to approve it.
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
hanzei
removed
2: Dev Review
Summary
Resolves ticket no #65 Allows multiple teams to have the same message without repeating them
Ticket Link
Fixes #65