Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds new node type 'highlight_without_notification' #17

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Adds new node type 'highlight_without_notification' #17

merged 1 commit into from
Nov 20, 2023

Conversation

M-ZubairAhmed
Copy link
Member

Summary

Added a new type of Node 'highlight_without_notification' which would be used for highlighting custom keywords with spaces

Ticket Link

n/a

larkox
larkox approved these changes Nov 17, 2023
View reviewed changes
Copy link

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this just needs type changes without almost no behavior change, but if it works, it works 😄

@M-ZubairAhmed M-ZubairAhmed merged commit 7a86080 into master Nov 20, 2023
12 checks passed
@M-ZubairAhmed M-ZubairAhmed deleted the highlihght-no-notif branch November 20, 2023 05:47
@M-ZubairAhmed M-ZubairAhmed restored the highlihght-no-notif branch November 20, 2023 05:50
@M-ZubairAhmed M-ZubairAhmed deleted the highlihght-no-notif branch November 20, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkox larkox larkox approved these changes

@hmhealey hmhealey Awaiting requested review from hmhealey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-ZubairAhmed @larkox