Changes made as Google uses a new datetime format #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My first ever contribution :) As of late 2021 / early 2022 Google uses timestamp instead of timestampMs with a new datetime format. Changes made to parse and convert. Name of JSON file to load changed to Records.json
|
I can confirm this patch works. Thank you! |
|
Thanks for the PR @Highlanderix ! |
|
Could one of you let me know if it makes sense to merge #8 as well? |
|
I didn't use #8 so can't reply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first ever contribution :)
As of late 2021 / early 2022 Google uses timestamp instead of timestampMs with a new datetime format. Changes made to parse and convert.
Name of JSON file to load changed to Records.json