Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Node: setMaintanceMode #74

Merged
merged 4 commits into from
Jun 23, 2024
Merged

Feature: Node: setMaintanceMode #74

merged 4 commits into from
Jun 23, 2024

Conversation

DerMistkaefer
Copy link
Contributor

This PR introduces the functionality to set a Node into Maintenance Mode.

API Doc:
https://dashflo.net/docs/api/pterodactyl/v1/
image

@lokerhp
Copy link
Contributor

lokerhp commented Dec 28, 2023

Personally I would change hasMaintanceMode into isInMaintenanceMode or inMaintenanceMode or something like that

@DerMistkaefer
Copy link
Contributor Author

Thank you for your suggestion regarding the naming convention.
Based on your feedback, I have updated the property to a more descriptive name, isInMaintenanceMode.
However, I have decided to keep the function name as setMaintanceMode to maintain consistency with the existing getter hasMaintanceMode, as referenced in Entity Node L45.
This balance allows us to improve clarity while preserving coherence in our codebase.

mattmalec
mattmalec requested changes Jan 2, 2024
View reviewed changes
Copy link
Owner

@mattmalec mattmalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey there! thanks so much for your contribution to p4j! just some small nitty changes, and then it should be good to go :)

src/main/java/com/mattmalec/pterodactyl4j/requests/action/AbstractNodeAction.java Outdated Show resolved Hide resolved
src/main/java/com/mattmalec/pterodactyl4j/application/managers/NodeAction.java Outdated Show resolved Hide resolved
@DerMistkaefer
Copy link
Contributor Author

DerMistkaefer commented Jan 2, 2024 •
edited
Loading

Thank you for your feedback. I don't want to change the old function name but when you say it is okay then let's go.
Now we use correct naming.

@DerMistkaefer
Copy link
Contributor Author

@mattmalec can we please merge this?

mattmalec
mattmalec requested changes Jan 13, 2024
View reviewed changes
Copy link
Owner

@mattmalec mattmalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super quick changes and i will approve + merge today

src/main/java/com/mattmalec/pterodactyl4j/application/entities/Node.java Outdated Show resolved Hide resolved
mattmalec
mattmalec approved these changes Apr 7, 2024
View reviewed changes
Copy link
Owner

@mattmalec mattmalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@mattmalec mattmalec merged commit 1b8825f into mattmalec:develop Jun 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmalec mattmalec Awaiting requested review from mattmalec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DerMistkaefer @lokerhp @mattmalec