Support prow #174
Draft
Support prow #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
dhiller
force-pushed
the
support-prow-directly
branch
2 times, most recently
from
c00a60a
to
f2b7145
Compare
gdm85
approved these changes
Nov 4, 2020
README.md
Outdated
|
|
||
| Goveralls can be used in [prow](https://github.com/kubernetes/test-infra/tree/master/prow) presubmit jobs, picking up the prow [environment variables](https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md#job-environment-variables) `PULL_REFS` and `PULL_NUMBER` to determine the branch and PR number automatically. | ||
|
|
||
| To avoid leaking your coveralls repo token you can use the `COVERALLS_TOKEN_FILE` env variable, so that a token gets read and used in the api call. |
There was a problem hiding this comment.
Suggested change
| To avoid leaking your coveralls repo token you can use the `COVERALLS_TOKEN_FILE` env variable, so that a token gets read and used in the api call. | |
| To avoid leaking your coveralls repo token you can use the `COVERALLS_TOKEN_FILE` env variable, so that a token gets read and used in the API call. |
dhiller
force-pushed
the
support-prow-directly
branch
from
f2b7145
to
5e30127
Compare
Hey, thanks for taking a look! Unfortunately I can't prove that this works right away, this PR was just a capturing of how it should work. Am currently working on setting up a demo of how this is supposed to work. Will get back when I have something to show. |
Instead of requiring to map the prow env vars to other values, directly use the env vars defined here: https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md#job-environment-variables Add paragraph to README.md explaining the usage.
dhiller
force-pushed
the
support-prow-directly
branch
from
5e30127
to
9888fb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring to map the prow env vars to other values, directly
use the env vars defined here:
https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md#job-environment-variables