Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set AppPool to "No Managed Code" when empty string used in config value: IIS-App-Pool-Dot-Net-Version #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Hendy
Copy link

@Hendy Hendy commented Aug 4, 2021

When attempting to set the runtime version to "No Managed Code" by setting the "IIS-App-Pool-Dot-Net-Version" in the iis-config.json to an empty string, the original code defaulted to setting the .NET CLR Version to "v4.0", but this change (which looks like it shouldn't behave any differently !) will set it to "No Managed Code".

When attempting to set the runtime version to "No Managed Code" by setting the "IIS-App-Pool-Dot-Net-Version" in the iis-config.json to an empty string, the original code defaulted to setting the .NET CLR Version to "v4.0", but this change (which looks like it shouldn't behave any differently !) will set it to "No Managed Code" for that empty string.
@Hendy Hendy changed the title Update IIS-Builder.ps1 Set AppPool to "No Managed Code" when empty string used in config value: IIS-App-Pool-Dot-Net-Version Aug 4, 2021
@mattou07
Copy link
Owner

Sorry Hendy for taking so long to get back to you. Just to confirm, you saying when you set the IIS-App-Pool-Dot-Net-Version to an empty string it just defaults to v4.0?

I cannot replicate this on Windows 10 Home or Windows 10 Pro. When I set the following json:

{
    "IIS-Site-Name": "test-site-hendy",
    "App-Pool-Name": "test-site-hendy",
    "IIS-App-Pool-Dot-Net-Version": "",
    "bindings": ["test-site-hendy.localtest.me"]
}

It sets the .NET version correctly:
image

Then again your changes are not changing much and I was able to setup my IIS site with your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants