Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remember the current schedule #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blundell
Copy link

@blundell blundell commented Apr 10, 2023

Currently when you toggle charging on and off from HomeAssistant, it replaces whatever current schedule you have with a schedule of 00:00 - 00:01.

This change passes the Pod details in an attempt to retain the current schedule (by re-using whatever schedule was on the first day for every day).

  • Passes on the schedule from the current pod
  • Uses the times from the first scheduled day for all days

(N.b. I haven't done any actual testing of this change - its more of a suggestive change, if you could validate the idea 😄)

- Passes on the schedule from the current pod
- Uses the times from the first scheduled day for all days
@mattrayner
Copy link
Owner

Thanks for your contribution, this is a really great enhancement, I'm fixing support for charge overrides but once that's in place I'll work on this slightly, I should be able to support keeping all the schedules rather than just copying day 1 through the whole week

@mattrayner mattrayner self-assigned this May 2, 2023
@mattrayner mattrayner added the enhancement New feature or request label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants