Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to use bbs-signatures #19

Merged
merged 4 commits into from
Jul 28, 2020
Merged

feat: switch to use bbs-signatures #19

merged 4 commits into from
Jul 28, 2020

Conversation

tplooker
Copy link
Member

@tplooker tplooker commented Jul 17, 2020

Description

Shifts to using bbs-signatures instead of node-bbs-signatures. This means the library can be used in browser and react native environments.

The un-resolved question is centered around why tests need to be executed in node environments (see here)

Also blocked by a stable release for bbs-signatures

Resolves #13

  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) follow conventional commits
  • Documentation has been added / updated (for bug fixes / features)
  • Changes follow the contributing document.

Motivation and Context

Greater support of the TS/JS ecosystem

Does this PR introduce a breaking change?

  • Yes
  • No

Which merge strategy will you use?

  • Squash
  • Rebase (REVIEW COMMITS)

@github-actions
Copy link

Total Coverage: 97.22%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   Bls12381G2KeyPair.ts89.47%94.44%97.18%105, 106, 108, 180, 248, 255
   index.ts100%100%100%

@github-actions
Copy link

Total Coverage: 97.22%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   Bls12381G2KeyPair.ts89.47%94.44%97.18%105, 106, 108, 180, 248, 255
   index.ts100%100%100%

@github-actions
Copy link

Total Coverage: 97.22%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   Bls12381G2KeyPair.ts89.47%94.44%97.18%105, 106, 108, 180, 248, 255
   index.ts100%100%100%

@tplooker tplooker marked this pull request as ready for review July 28, 2020 05:33
@tplooker tplooker merged commit ca85df2 into master Jul 28, 2020
@tplooker tplooker deleted the tl/wasm-support branch July 28, 2020 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add support for bbs-signatures library
1 participant