-
Notifications
You must be signed in to change notification settings - Fork 41
feat: add support for bbs-signatures library #61
feat: add support for bbs-signatures library #61
Conversation
Tests are passing on local. Looks like the actual issue was just to do with the heap overflow. The latest commit should fix that. |
Looks like we faced the same issue after the latest commit as described here - mattrglobal/bbs-signatures#35 Will resolve using the workaround here - https://github.com/mattrglobal/bls12381-key-pair/pull/19/files#diff-2d0cd5d10b9604941c38c6aac608178aR7 |
Unable to reproduce the errors being faced in the github workflow runner on my local. Will be doing some debugging on here directly. We can squash the commits later during merge. |
The tests are passing fine now. We believe the coverage is failing because this is a PR from my fork of the project, and the Github secret token is not being shared with my fork. |
Solves #57
Description
Removes the dependency on
node-bbs-signatures
and adds a dependency onbbs-signatures
which has the node fallback built in now.Motivation and Context
To allow this library to run in non-node environments (browser, wasm, non-wasm e.g. react native)
Does this PR introduce a breaking change?
Which merge strategy will you use?