-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support asynchronous mode #1391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should we think about raising the minimum version requirement to Python3.9? |
I like this! We can jump to even newer versions if it is worth it. DM me on twitter if you want to chat with us. |
Thank you so much and congratulations for such important contribution!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
--async
parameter to enable asynchronous mode (close #643). In asynchronous mode, coroutines are used instead of threads to send network requests (usehttpx
).I ran a few quick tests and found that the asynchronous mode really speeds up the scanning process. (
uvloop
can makes it even faster)This PR isn't quite finished yet!
Should we replace requests with httpx? Since httpx supports both synchronous and asynchronous modes.There should be a new issue for discussion.httpx
requires 3.8+)httpx
doesn't let me choose different proxy for each request.Requirements
CONTRIBUTORS.md
CHANGELOG.md