Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full gimbal angle control #328

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Full gimbal angle control #328

merged 3 commits into from
Jan 23, 2024

Conversation

Daybreakerflint
Copy link
Contributor

This feature is a request as I have to use the gimbal I have in a certain way and the roll and pitch axis are switched.
As the pitch of the payload of the gimbal is vitally important, this feature is needed.

@JonasVautherin
Copy link
Collaborator

and the roll and pitch axis are switched

Can you elaborate a bit? I am not sure I understand what this means... Are you saying that your Gimbal is reading the MAVLink message incorrectly, and therefore you want to invert the values you send from MAVSDK instead of fixing the Gimbal side?

@Daybreakerflint
Copy link
Contributor Author

Hey Jonas!
I do not just want to invert the control, as my setup needs it because how i have it the gimbal is balanced and I have the least amount of weight.

My payload on the gimbal is a quad rigged horn antenna. An antenna with two polarization.
Because the drone payload is sensitive to such things as alignment. Meaning also how the polarization is to the object.
IMG_20240109_153559

The gimbal is reading everything ok. I just want full control of where it points to.

@JonasVautherin
Copy link
Collaborator

I see, so you need the roll axis. It was initially not exposed because cameras don't really need to set the roll axis 😇.

@julianoes: do you have an opinion on that?

Comment on lines 84 to 86
float pitch_deg = 1; // Pitch angle in degrees (negative points down)
float yaw_deg = 2; // Yaw angle in degrees (positive is clock-wise, range: -180 to 180 or 0 to 360)
float roll_deg = 3; // Roll angle in degrees
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please change the order of the fields to match the usual MAVLink order: roll, pitch, yaw.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Shall I do it, or do you do it? As I said, this is my first time. Happy to help where I can.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you change it. Thanks!

@julianoes julianoes merged commit 736bc2a into mavlink:main Jan 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants