ftp: split list_directory response #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
force-pushed
the
pr-ftp-list-dir-api
branch
2 times, most recently
from
6deaae8
to
3913f1e
Compare
|
Note to self: remove the offset numbers behind the filenames. |
julianoes
force-pushed
the
pr-ftp-list-dir-api
branch
2 times, most recently
from
6d2a264
to
a11cf2d
Compare
JonasVautherin
previously approved these changes
Jun 11, 2024
We already use the queue when calling the user callback, so we don't need to do it internally as well.
This way we get a clear list of files and folders instead of an odd list with F or D prefixes.
julianoes
force-pushed
the
pr-ftp-list-dir-api
branch
from
49bd8b3
to
33929d1
Compare
Otherwise we seem to lock ourselves out when trying to add the FTP download item to the queue.
julianoes
force-pushed
the
pr-ftp-list-dir-api
branch
from
33929d1
to
2607261
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we get a clear list of files and folders instead of an odd list with F or D prefixes.
Depends on mavlink/MAVSDK-Proto#343.
Closes #2308.