Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Onboarding Flow): image in the searching mosque, and Invalid index #1068

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

YassinNouh21
Copy link
Contributor

@YassinNouh21 YassinNouh21 commented Mar 19, 2024

📝 Summary

This PR integrates new onboarding state management, and includes a module for shared preferences. It also streamlines the OnBoardingState class and ensures a default image is used for the mosque model when none is provided. Fix the issue of invalid

Description

  • Integrated new onboarding state management to improve user experience during the app setup.
  • Introduced DeviceState and DeviceNotifier for managing device-specific states such as language and orientation.
  • Implemented a shared preference module to facilitate easy access to user preferences across the app.
  • Streamlined the OnBoardingState class for better readability and maintainability.

Tests

🧪 Use case 1

💬 Description:
Tested the onboarding process to ensure that the new state management works as expected. Verified that the default image is correctly used when no mosque image is provided. Checked the functionality of device state management by changing the device language and orientation.

📷 Screenshots or GIFs (if applicable):
N/A

Checklist:

  • Coding Standards: I have reviewed my code to ensure it follows the project's coding standards.
  • Testing: I have tested the changes and they work as expected.
  • Merge Conflicts: I have resolved any merge conflicts with the latest main/development branch.
  • Branch Status: The branch is up-to-date with the target branch (main/development).

@YassinNouh21 YassinNouh21 added the bug Something isn't working label Mar 19, 2024
Copy link
Contributor

@ghassenbenzahra123 ghassenbenzahra123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the mosque type is home after selecting the mosque from the search screen you must be redirected directly to the homepage you dont see regular mode or announcement mode screen & main screen or secondary screen.

@YassinNouh21 YassinNouh21 marked this pull request as draft September 30, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants