refactor: remove the successful download for quran dialog #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here’s your updated PR description based on the patch and the details you provided:
📝 Summary
This PR fixes #1446
This PR refactors the DownloadQuranDialog widget to remove the business need for displaying a dialog upon successful Quran download. The success state is now handled silently by closing the current dialog without showing a success message or dialog to the user. This change simplifies the user experience and reduces potential performance overhead, especially on devices with limited hardware capabilities.
Tests
🧪 Use Case 1
💬 Description:
Launch the app and trigger a Quran download. Verify the following:
• Once the download is successful, the dialog is dismissed automatically.
• No success dialog or additional UI elements are displayed.
• The state transitions smoothly without affecting the user experience.
📷 Screenshots or GIFs (if applicable):
(Not applicable for this PR, as no new UI elements are introduced.)