-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/ Optimize and Add Loading Indicator for Auto-Scroller in Reading #1475
Open
ghassenbenzahra123
wants to merge
21
commits into
release-1.18.0
Choose a base branch
from
refactor/quran/optimize_reading_auto_scroll
base: release-1.18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/ Optimize and Add Loading Indicator for Auto-Scroller in Reading #1475
ghassenbenzahra123
wants to merge
21
commits into
release-1.18.0
from
refactor/quran/optimize_reading_auto_scroll
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to_scroll # Conflicts: # lib/src/state_management/quran/reading/quran_reading_notifer.dart
YassinNouh21
force-pushed
the
refactor/quran/optimize_reading_auto_scroll
branch
from
December 17, 2024 08:30
4c092f1
to
eadc21d
Compare
YassinNouh21
force-pushed
the
refactor/quran/optimize_reading_auto_scroll
branch
from
December 17, 2024 09:13
eadc21d
to
d5cd6dd
Compare
YassinNouh21
force-pushed
the
refactor/quran/optimize_reading_auto_scroll
branch
from
December 19, 2024 06:29
91a5f76
to
db4b0d3
Compare
…to_scroll # Conflicts: # lib/l10n/intl_en.arb # lib/src/pages/quran/reading/quran_reading_screen.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR fixes: #1466
Description
This PR addresses the issue of overlapping pages during auto-scroll in Quran reading mode by implementing a more strict approach to page layout and scaling. Key improvements include:
The changes ensure each page takes exactly one screen height without overlapping the next/previous pages while maintaining proper scaling of the Quran text.
Tests
🧪 Use case 1
💬 Description:
📷 Screenshots or GIFs (if applicable):
[Screenshots showing smooth page transitions without overlap]
🧪 Use case 2
💬 Description:
Checklist: