Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move Surah Selector to Avoid Overlapping Text #1491

Open
wants to merge 3 commits into
base: release-1.18.0
Choose a base branch
from

Conversation

YassinNouh21
Copy link
Contributor

@YassinNouh21 YassinNouh21 commented Dec 21, 2024

📝 Summary

This PR fixes #1492

Problem

The Surah selector overlaps the Quranic text, making it less readable. There is available space at the bottom of the screen that can be utilized to resolve this issue.

Solution

  • Adjusted the position of the Surah selector by adding a margin at the top (top: 0.65.h) to move it further down.
  • Improved padding for better alignment and spacing:
    • Horizontal padding set to 2.w.
    • Vertical padding set to 0.75.h.
  • Increased the background opacity of the selector to 0.6 for better contrast without obscuring content.

Impact

  • The Quran is no longer overlapped by the Surah selector.
  • Improved readability and UI consistency.

image

@YassinNouh21 YassinNouh21 self-assigned this Dec 21, 2024
@YassinNouh21 YassinNouh21 added the bug Something isn't working label Dec 21, 2024
@YassinNouh21 YassinNouh21 linked an issue Dec 22, 2024 that may be closed by this pull request
@YassinNouh21
Copy link
Contributor Author

@ghassenbenzahra123 has detected this issue
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Surah Selector Overlaps Quran
1 participant