Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(#2): removed modified property in translation file #121

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

Aerex
Copy link
Collaborator

@Aerex Aerex commented Nov 17, 2023

Context

The modified property is causing problems when running the checkup command. Currently, the property is not being used in the codebase. I think it was intended to track what translation files have changed to be processed when running the fixup command.

This PR will remove the modified property

#120

Run Unit Tests

  1. Run the command: ./bin/test
  2. Verify that all test pass

@Aerex Aerex requested a review from maximilien November 17, 2023 02:54
@Aerex Aerex force-pushed the refactor/120-removed-unused-modified-property branch from 3c94a1a to b6b5b24 Compare November 17, 2023 02:58
@Aerex Aerex force-pushed the refactor/120-removed-unused-modified-property branch from b6b5b24 to 9b4f009 Compare November 17, 2023 02:59
@Aerex Aerex changed the title refactor: removed modified property in translation file refactor(#2): removed modified property in translation file Nov 27, 2023
Copy link
Owner

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@maximilien
Copy link
Owner

Please resolve @Aerex

@Aerex Aerex merged commit d4468af into master Nov 28, 2023
5 checks passed
@Aerex Aerex deleted the refactor/120-removed-unused-modified-property branch November 28, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants