-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependencies and now compatible from netstandard2.0 to net8.0 #166
Conversation
I've updated all dependencies and reverded the base target from netstandard2.1 (introduced in ver 1.2.7) to netstandard2.0 as this keeps it compatible with the widely used Net Framework 4.8. Added net4.8 to tests and adapted appsettings.json code to work on every platform. All tests passed on all targets.
@energywave thanks for the PR! The way it works, there is an environment variable named GOOGLE_API_KEY with the key that's used in the tests. |
Hello, yes I've seen it was trying to get the key from app settings.json and, if not available there, it was getting from the environment variable. |
Another suggestion is to split this PR to smaller chunks, so it'll be easier to merge it |
Sorry that I could not work on that sooner. When I submitted my PR I was using the appsettings to set my google apy key so I had the doubt that setting the environment variable did not work. So I tested it yesterday and... it just works correctly!
And now is:
As you see the environment should work. The only reason because it would not pick up the environment variable is if it finds an appsettings and it contains the GOOGLE_APY_KEY variable. |
Furthermore... I think we have to update the nuget.yml adding other targets accordint to .net standard 2.0 but, again, I never used github workflow, so maybe it's better that you fix it the proper way. |
I think that something with the jobs for PRs isn't set right and you're just not getting the key. I'll check that. |
Published v 1.3.3 |
Wonderful, thank you! I've updated on of my softwares where I was referencing my PR in the solution, by now referencing the newly published package from NuGet and it works flawlessy in .net framework 4.8. |
Yeah, I checked the github actions documents. Looks like I need to clone your PR to a local branch and then run it there. I'll do that for next time. |
All tests passed on all targets.
I'm already using in one of my .net 4.8 WinForms project and it's working flawlessy.