New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use http location for jQuery #34

Open

matenia wants to merge 2 commits into maxwell:master from reinteractive:http-google-endpoint

matenia commented Apr 10, 2016

I noticed that includeJs won't run callbacks when you're including a https source, therefore ignoring all options.

using http source for jQuery (unsure of the implications at this point)
fixed a few broken specs
locked PhantomJs to 1.9.8.0

There are a few other pull requests that touch on this problem. This felt like the simplest thing that could possibly work.

matenia added 2 commits

April 5, 2016 10:49


          Use http endpoint for jquery as https doesn't run the callback

6ba899e


          lock phantomjs version + fix specs

1eef6f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet