feat: Web UI のノードやボタンの遷移先を調整できるようにする #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISUCONお疲れ様でした。素晴らしいツールをありがとうございます。
使ってみて一点不便なことがあったので、PRを作成しました。
Web UI をリバースプロキシの後ろに置くと、ノードをクリックしたときの遷移がうまくいきません。
以下は Caddyfile の例です。
localhost:8080/isucrud
で Mermaid を見ることはできますが、クリックの遷移先がlocalhost:8080/?node=
になります。上記の問題を解消するため、遷移先の base path を指定するオプションを追加しました。
動作確認:
feat-isucrud.mov