Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Web UI のノードやボタンの遷移先を調整できるようにする #38

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

harsssh
Copy link
Contributor

@harsssh harsssh commented Dec 10, 2024

ISUCONお疲れ様でした。素晴らしいツールをありがとうございます。
使ってみて一点不便なことがあったので、PRを作成しました。

Web UI をリバースプロキシの後ろに置くと、ノードをクリックしたときの遷移がうまくいきません。
以下は Caddyfile の例です。localhost:8080/isucrud で Mermaid を見ることはできますが、クリックの遷移先が localhost:8080/?node= になります。

# Example Caddyfile
:8080

handle /isucrud {
    reverse_proxy :7070
}

上記の問題を解消するため、遷移先の base path を指定するオプションを追加しました。

isucrud -web -base /isucrud ./...

動作確認:

feat-isucrud.mov

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (1c630e3) to head (d578d99).

Files with missing lines Patch % Lines
internal/ui/render.go 0.00% 9 Missing ⚠️
internal/ui/mermaid.go 0.00% 2 Missing ⚠️
main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #38   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         14      14           
  Lines        971     978    +7     
=====================================
- Misses       971     978    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mazrean mazrean merged commit 14ce37f into mazrean:main Dec 10, 2024
3 checks passed
@mazrean
Copy link
Owner

mazrean commented Dec 10, 2024

ありがとうございます!
良さそうだったのでマージしました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants