Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove location in modules_in_project_directory_on_harddisk_but_not_added_to_project linter #251

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Remove location in modules_in_project_directory_on_harddisk_but_not_added_to_project linter #251

merged 2 commits into from
Nov 27, 2024

Conversation

lukewoodcock
Copy link
Collaborator

This PR is a quick fix that removes the location from the reported error. This avoid incompatible whitelists between platforms, and breaking the location link when using the relative paths

@lukewoodcock
modules_in_project_directory_on_harddisk_but_not_added_to_project:
a6d7a78 
-handle empty parameter
-update documentation
alexanderpann
alexanderpann reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@alexanderpann alexanderpann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is a small typo in the description of the parameter.
  • What is the purpose of adding "empty" as an error if the root path is empty?

@lukewoodcock
Copy link
Collaborator Author

  • There is a small typo in the description of the parameter.
  • What is the purpose of adding "empty" as an error if the root path is empty?
  • Typo fixed
  • Excuse me. It was just a piece of debugging code which clearly I missed when cleaning up for the PR 😊

alexanderpann
alexanderpann approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@alexanderpann alexanderpann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lukewoodcock lukewoodcock merged commit 18f65ea into maintenance/MPS-2023.2 Nov 27, 2024
1 check passed
@lukewoodcock lukewoodcock deleted the bugfix/remove_location branch November 27, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderpann alexanderpann alexanderpann approved these changes

@sergej-koscejev sergej-koscejev Awaiting requested review from sergej-koscejev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukewoodcock @alexanderpann